fix(Guild): guild.available is never set on new joins #6769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess this bug caused #6595 |
That issue was made long before the pull request that introduced this bug was |
kyranet
requested changes
Oct 7, 2021
…cks, and avoid an unnecessary assignment.
kyranet
approved these changes
Oct 8, 2021
vladfrangu
approved these changes
Oct 8, 2021
iCrawl
approved these changes
Oct 8, 2021
SpaceEEC
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This fixes a bug that was introduced in #6694 where, if the
datapassed to the constructor of a Guild doesn't explicitly have theunavailablefield, then the correspondingavailablefield of the cached Guild will never be set, resulting inthis.availablereturningundefined(false-y) despite the guild being available.This scenario specifically happens when inviting a bot to a new guild since the
unavailablefield is missing, whereas theGUILD_CREATEevent the client receives on startup has the field and is processed correctly.Status and versioning classification: