fix(User): don't generate the banner URL when not cached #6783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noxzym
reviewed
Oct 7, 2021
|
Because a null banner means the banner is not set and an undefined banner means it is not cached. In the PR that introduced that I decided to go with the error approach so that users didn't think the user had no banner. Maybe it could've returned undefined, but the PR has already been merged (see #6721) |
SpaceEEC
approved these changes
Oct 8, 2021
kyranet
approved these changes
Oct 8, 2021
vladfrangu
approved these changes
Oct 8, 2021
iCrawl
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR fixes a bug with User#toJSON that would throw an error when the banner wasn't cached. This was changed to make the property undefined instead to allow users to generate the JSON object without this error being thrown as this was quite confusing for some users.
Status and versioning classification: