fix(Webhook): Resolve source guild only if cached #6834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladfrangu
approved these changes
Oct 14, 2021
SpaceEEC
approved these changes
Oct 16, 2021
iCrawl
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This resolves #6773 (tl;dr: checking the
.sourceGuildproperty of a channel follower webhook that the bot is not in (or has cached) yields a weirdGuildstructure with improperly-set &undefinedproperties).I went with the
.resolve()approach here as trying to movefeaturesout of theBaseGuildand no longer having it abstract would mean that another abstract intermediary guild structure would have to be created just forfeatures, which is a bit much. In addition, if we were to create aSourceGuildstructure, it would be somewhat of a copy of the existingBaseGuild, which I don't think is desired.Status and versioning classification: