fix(MessageComponentInteraction): component getter is not null anymore #6835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Update typings and also please follow the PR template |
|
no problem. will do [Update 16:56]: Added relevant changes to typings, PR adheres to template now. |
Updated typings/index.d.ts
vladfrangu
previously requested changes
Oct 14, 2021
chrdek
commented
Oct 14, 2021
iCrawl
approved these changes
Oct 18, 2021
chrdek
changed the title
|
Changed title to the standard of template. |
|
Couldn't this still be null in a partial Message? |
|
Hi, from another quick view around the codebase, I believe MessageComponent itself doesn't set any null data irrespective of any partial or normal message event updates in it. Check out file: The updates mentioning the changed lines of issue #6481 include customId which also cannot be null /whole component cannot default to null. |
SpaceEEC
approved these changes
Oct 24, 2021
vladfrangu
approved these changes
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This refers issue #6481 - The component getter of a MessageComponentInteraction cannot be null.
Removed null coal. from both TS typings/main getter of the component.
(following init commit of d6e6244)
Status and versioning classification: