feat(ApplicationCommand): add support for min and max values #6855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
reviewed
Oct 18, 2021
ImRodry
reviewed
Oct 18, 2021
vladfrangu
previously requested changes
Oct 24, 2021
vladfrangu
approved these changes
Oct 26, 2021
kyranet
approved these changes
Oct 29, 2021
|
@ckohen a question. About a week has passed since upstream PR were merged, can you tell me why typings are not yet available? note: IK rebase isn't required but can you please rebase your fork. Thanks |
|
Unfortunately the question in the upstream PR was not answered, so I think I'm just going to have to make a decision and leave the typings less strict 😢. |
Co-authored-by: Noel <buechler.noel@outlook.com>
Co-Authored-By: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
ckohen
force-pushed
the
options-max-min
branch
from
e6aa42b
to
b186cc6
Compare
samarmeena
reviewed
Nov 9, 2021
samarmeena
reviewed
Nov 9, 2021
Jiralite
reviewed
Nov 9, 2021
samarmeena
approved these changes
Nov 9, 2021
Mysterious-Dev
approved these changes
Nov 9, 2021
|
Assuming this PR is completed and it's been over a week since upstream PR merged. May I ask what's stopping this PR to merge into main? Curious to try this update. |
SpaceEEC
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds support for number and int types max and min values
Typings are not yet updated due to a potential issue with choices and min / max that I will be noting upstream
Status and versioning classification: