fix(TextBasedChannel): return the cached message instead of clone it #6877
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This probably will also fix #6348 and #6763 about the
.deleted
flags that does never get updated. Their code example wasn't usingsetTimeout
and makes it looks like a race condition. But actually I also encounter about this problem and found that the returned object fromtextChannel.send
is cloned from the original object, while the cache only stored the original message object. The.deleted
flag on cached message will get updated, but the cloned message will never get updated because the object property is copied by usingObject.assign
from the._clone
method.The code sample about this fix:
Result:
Status and versioning classification: