New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(MessageEmbed): add #equals #6885
Conversation
What is that supposed to mean @wutv |
your code seems slightly unnecessary |
that function basically has the same purpose as yours, except its smaller |
Ok now try comparing two real embeds that are equal but attached to different objects. That's the point of this function and functions like this exist across the library so please show me better examples |
May I ask why |
To be consistent with other methods such as |
Please describe the changes this PR makes and why it should be merged:
This PR adds the MessageEmbed#equals and the MessageEmbed#_fieldEquals methods (the latter being private) in order to allow for the comparison of two embed objects (while also accepting raw API embed objects). I stumbled across a scenario in one of my projects where I had to compare two embeds entirely so I figured I might as well add this to the library itself.
Status and versioning classification: