feat(ThreadMemberManager): allow individual members to be fetched #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckohen
requested changes
Oct 26, 2021
Co-authored-by: ckohen <chaikohen@gmail.com>
ckohen
requested changes
Oct 26, 2021
Co-authored-by: ckohen <chaikohen@gmail.com>
ckohen
approved these changes
Oct 26, 2021
ImRodry
reviewed
Oct 26, 2021
suneettipirneni
force-pushed
the
feat/thread-member-fetching
branch
from
edff924
to
e1b653c
Compare
vladfrangu
previously requested changes
Oct 26, 2021
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
SpaceEEC
previously requested changes
Oct 27, 2021
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
iCrawl
approved these changes
Oct 27, 2021
kyranet
requested changes
Oct 28, 2021
vladfrangu
approved these changes
Oct 28, 2021
…eat/thread-member-fetching
…ettipirneni/discord.js into feat/thread-member-fetching
kyranet
requested changes
Oct 29, 2021
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
SpaceEEC
approved these changes
Oct 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Currently
ThreadMemberManager#fetchreturns all members in the thread all at once. With this PR you also have to option to fetch individual members whom are part of a thread.I'm assuming that this PR isn't breaking simply because
#fetch(true)and#fetch()both behave the same way, and return the same thing. The additional params introduced now change the return types, but only when they are used.ref:
Status and versioning classification: