fix: assert channel types in message actions #6919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR ensures that message related actions take place in a channel that is supported to avoid throwing an unhandled exceptions. (Read: text in voice, also future-proofing)
Changed actions:
The reaction actions previously were ensuring that the action was not taking place in a voice channel (as per type) and the typing start action in a text channel (as per type).
I went with
Channel#isText
since it seems to be the less error-prone method to check whether messages can be accessed in said channel, since it's justreturn 'messages' in this
.Status and versioning classification: