Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly access guild IDs inside managers #6927

Merged
merged 1 commit into from Nov 1, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Oct 31, 2021

Please describe the changes this PR makes and why it should be merged:
This PR fixes a stupid oversight introduced in #6875 where guild IDs were incorrectly accessed through the manager instead of through the guild. My bad!

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the Version 13.4 milestone Nov 1, 2021
@iCrawl iCrawl merged commit 2d9ffb8 into discordjs:main Nov 1, 2021
@ImRodry ImRodry deleted the fix-setpositions-id branch November 1, 2021 14:13
@ImRodry
Copy link
Contributor Author

ImRodry commented Nov 1, 2021

@iCrawl could you release a patch version with this fix and some other semver patch commits?

@iCrawl iCrawl modified the milestones: Version 13.4, Version 13.3.1 Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants