Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MessageReaction): Cache myself when MessageReaction#me is true. #6956

Merged
merged 1 commit into from Nov 11, 2021
Merged

fix(MessageReaction): Cache myself when MessageReaction#me is true. #6956

merged 1 commit into from Nov 11, 2021

Conversation

GrapeColor
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
It is inconsistent that I am not cached in ReactionUserManager when MessageReaction#me is true.
So when I create a ReactionUserManager, I cache myself.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably falls under the partial-undefined-state-ness, but I suppose this doesn't hurt. 🤷

@iCrawl iCrawl added this to the Version 13.4 milestone Nov 11, 2021
@iCrawl iCrawl merged commit b001e19 into discordjs:main Nov 11, 2021
@GrapeColor GrapeColor deleted the cache-myself-to-reaction-user-manager branch November 12, 2021 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants