Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add UserContextMenuInteraction and MessageContextMenuInteraction #7003

Merged
merged 17 commits into from Dec 1, 2021
Merged

feat: add UserContextMenuInteraction and MessageContextMenuInteraction #7003

merged 17 commits into from Dec 1, 2021

Conversation

GrapeColor
Copy link
Contributor

@GrapeColor GrapeColor commented Nov 18, 2021 •
edited

Please describe the changes this PR makes and why it should be merged:
Add UserContextMenuInteraction and MessageContextMenuInteraction.
Add targetUser and targetMember properties in UserContextMenuInteraction.
Add a targetMessage property in MessageContextMenuInteraction.

Currently, the context menu interaction is unified to ContextMenuInteraction.
Therefore, target users and messages must use interaction.options.getUser('user') and interaction.options.getMessage('message').
This isn't intuitive, so we'll separate the classes and add getter functions.

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

suneettipirneni
suneettipirneni reviewed Nov 18, 2021
View reviewed changes
Copy link
Member

@suneettipirneni suneettipirneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing something here, but where are these new classes being created in the lib? The typeguard is misleading if the actual runtime version of the class is still a ContextMenuInteraction and not a more specific type.

@GrapeColor
Copy link
Contributor Author

GrapeColor commented Nov 19, 2021 •
edited

I might be missing something here, but where are these new classes being created in the lib? The typeguard is misleading if the actual runtime version of the class is still a ContextMenuInteraction and not a more specific type.

I'm sorry.
Now I have added new classes to the InteractionCreate.

suneettipirneni
suneettipirneni requested changes Nov 19, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu requested changes Nov 23, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
typings/index.d.ts Outdated Show resolved Hide resolved
GrapeColor and others added 2 commits November 23, 2021 22:05
@GrapeColor @vladfrangu
fix: add readonly flag to MessageContextMenuInteraction
1d38370 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@GrapeColor @vladfrangu
fix: add readonly flags to UserContextMenuInteraction
0b75821 
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
@GrapeColor
Copy link
Contributor Author

Thank you all for your helps.

@GrapeColor
Copy link
Contributor Author

I'm sorry for your review.
I forgot to add the classes to index.js.
Really sorry.

@iCrawl iCrawl added this to the Version 13.4 milestone Dec 1, 2021
@iCrawl iCrawl merged commit 4fe063f into discordjs:main Dec 1, 2021
@GrapeColor GrapeColor deleted the separate-context-menu-for-each-type branch December 1, 2021 11:49
Koyamie added a commit to Koyamie/discord.js that referenced this pull request Dec 2, 2021
@Koyamie
Squashed commit of the following:
7dbc566 
commit 01f8d1b
Author: Jiralite <33201955+Jiralite@users.noreply.github.com>
Date:   Thu Dec 2 13:29:54 2021 +0000

    types(Interaction): Narrow `memberPermissions` (discordjs#7054)

commit 5fcda73
Author: That_Guy977 <72870724+That-Guy977@users.noreply.github.com>
Date:   Thu Dec 2 20:29:21 2021 +0700

    fix(GuildChannel): default to `this.rawPosition` in `clone()` (discordjs#7057)

commit 552d89f
Author: Rodry <38259440+ImRodry@users.noreply.github.com>
Date:   Wed Dec 1 11:40:49 2021 +0000

    feat(Guild): add premiumProgressbarEnabled (discordjs#6887)

    Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>

commit b183a8e
Author: Rodry <38259440+ImRodry@users.noreply.github.com>
Date:   Wed Dec 1 11:33:28 2021 +0000

    docs(Invite): add info blocks for missing props (discordjs#7014)

commit da86bd4
Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
Date:   Wed Dec 1 06:33:11 2021 -0500

    fix: Interaction channel type should be `GuildTextBasedChannels` when in guild (discordjs#6998)

commit c07207f
Author: That_Guy977 <72870724+That-Guy977@users.noreply.github.com>
Date:   Wed Dec 1 18:32:13 2021 +0700

    fix(Util): fix sorting for GuildChannels (discordjs#7002)

commit 4fe063f
Author: GrapeColor <40069549+GrapeColor@users.noreply.github.com>
Date:   Wed Dec 1 20:31:37 2021 +0900

    feat: add `UserContextMenuInteraction` and `MessageContextMenuInteraction` (discordjs#7003)

    Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
    Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
    Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
    Co-authored-by: GrapeColor <grapecolor@users.noreply.github.com>

commit a39d8c4
Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
Date:   Wed Dec 1 06:28:22 2021 -0500

    Revert "types(ApplicationCommandManager): Deprecate old `*Data` type …usages and allow camel cased dapi types to be used (discordjs#7052)

commit 85e6812
Author: Jiralite <33201955+Jiralite@users.noreply.github.com>
Date:   Wed Dec 1 11:27:24 2021 +0000

    docs(MessageReference): Fix static link (discordjs#7041)

commit e305156
Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
Date:   Mon Nov 29 13:32:26 2021 -0500

    chore: bump deps (discordjs#7048)

commit 374f970
Author: Antonio Román <kyradiscord@gmail.com>
Date:   Mon Nov 29 11:20:52 2021 +0100

    chore: add myself as contributor in package.json (discordjs#7037)

commit e59fac3
Author: Antonio Román <kyradiscord@gmail.com>
Date:   Mon Nov 29 11:20:18 2021 +0100

    refactor(SnowflakeUtil): clean up utils and improve perf (discordjs#7036)

commit fd63139
Author: Antonio Román <kyradiscord@gmail.com>
Date:   Mon Nov 29 11:19:32 2021 +0100

    fix(MessageManager): do not use `client.emojis` (discordjs#7039)

commit 0193efa
Author: Antonio Román <kyradiscord@gmail.com>
Date:   Mon Nov 29 11:19:21 2021 +0100

    fix(ActionsManager): revert to manual requires (discordjs#7034)

commit fabd343
Author: Antonio Román <kyradiscord@gmail.com>
Date:   Mon Nov 29 11:18:41 2021 +0100

    fix(MessagePayload): prevent spread of `undefined` (discordjs#7029)

commit 2c91c48
Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com>
Date:   Mon Nov 29 05:17:57 2021 -0500

    types(ApplicationCommandManager): Deprecate old `*Data` type usages and allow camel cased dapi types to be used (discordjs#6959)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry left review comments

@almeidx almeidx almeidx left review comments

@suneettipirneni suneettipirneni suneettipirneni requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

Assignees
No one assigned
Labels
semver:minor typings
Projects
discord.js
Archived in project
Milestone
Version 13.4
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@GrapeColor @vladfrangu @iCrawl @kyranet @SpaceEEC @ImRodry @almeidx @suneettipirneni