fix: avoid sending bot auth on token endpoints #7022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Nov 22, 2021
vladfrangu
approved these changes
Nov 22, 2021
|
Can this get a higher priority? My bot has been getting 1 hour rate limits after very few interactions on the edit reply endpoint and I believe this PR would fix it, or at least I hope it does |
|
I recognize this has already been merged, however, it was stated by Discord that this is an internal bug in the platform, not something that libraries should need to handle. Just wanted to make sure that got resurfaced here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR changes requests that use a token to authorize themselves to not use bot auth (Authorization header).
See: discord/discord-api-docs#4142 (this might be fixed on Discord's end, but definitely can't hurt to be fixed here [too])
Status and versioning classification: