fix(MessageManager): do not use client.emojis
#7039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
approved these changes
Nov 27, 2021
iCrawl
approved these changes
Nov 29, 2021
Jiralite
pushed a commit
to Jiralite/discord.js
that referenced
this pull request
Dec 1, 2021
Koyamie
added a commit
to Koyamie/discord.js
that referenced
this pull request
Dec 2, 2021
commit 01f8d1b Author: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Thu Dec 2 13:29:54 2021 +0000 types(Interaction): Narrow `memberPermissions` (discordjs#7054) commit 5fcda73 Author: That_Guy977 <72870724+That-Guy977@users.noreply.github.com> Date: Thu Dec 2 20:29:21 2021 +0700 fix(GuildChannel): default to `this.rawPosition` in `clone()` (discordjs#7057) commit 552d89f Author: Rodry <38259440+ImRodry@users.noreply.github.com> Date: Wed Dec 1 11:40:49 2021 +0000 feat(Guild): add premiumProgressbarEnabled (discordjs#6887) Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> commit b183a8e Author: Rodry <38259440+ImRodry@users.noreply.github.com> Date: Wed Dec 1 11:33:28 2021 +0000 docs(Invite): add info blocks for missing props (discordjs#7014) commit da86bd4 Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Date: Wed Dec 1 06:33:11 2021 -0500 fix: Interaction channel type should be `GuildTextBasedChannels` when in guild (discordjs#6998) commit c07207f Author: That_Guy977 <72870724+That-Guy977@users.noreply.github.com> Date: Wed Dec 1 18:32:13 2021 +0700 fix(Util): fix sorting for GuildChannels (discordjs#7002) commit 4fe063f Author: GrapeColor <40069549+GrapeColor@users.noreply.github.com> Date: Wed Dec 1 20:31:37 2021 +0900 feat: add `UserContextMenuInteraction` and `MessageContextMenuInteraction` (discordjs#7003) Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com> Co-authored-by: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com> Co-authored-by: GrapeColor <grapecolor@users.noreply.github.com> commit a39d8c4 Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Date: Wed Dec 1 06:28:22 2021 -0500 Revert "types(ApplicationCommandManager): Deprecate old `*Data` type …usages and allow camel cased dapi types to be used (discordjs#7052) commit 85e6812 Author: Jiralite <33201955+Jiralite@users.noreply.github.com> Date: Wed Dec 1 11:27:24 2021 +0000 docs(MessageReference): Fix static link (discordjs#7041) commit e305156 Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Date: Mon Nov 29 13:32:26 2021 -0500 chore: bump deps (discordjs#7048) commit 374f970 Author: Antonio Román <kyradiscord@gmail.com> Date: Mon Nov 29 11:20:52 2021 +0100 chore: add myself as contributor in package.json (discordjs#7037) commit e59fac3 Author: Antonio Román <kyradiscord@gmail.com> Date: Mon Nov 29 11:20:18 2021 +0100 refactor(SnowflakeUtil): clean up utils and improve perf (discordjs#7036) commit fd63139 Author: Antonio Román <kyradiscord@gmail.com> Date: Mon Nov 29 11:19:32 2021 +0100 fix(MessageManager): do not use `client.emojis` (discordjs#7039) commit 0193efa Author: Antonio Román <kyradiscord@gmail.com> Date: Mon Nov 29 11:19:21 2021 +0100 fix(ActionsManager): revert to manual requires (discordjs#7034) commit fabd343 Author: Antonio Román <kyradiscord@gmail.com> Date: Mon Nov 29 11:18:41 2021 +0100 fix(MessagePayload): prevent spread of `undefined` (discordjs#7029) commit 2c91c48 Author: Suneet Tipirneni <77477100+suneettipirneni@users.noreply.github.com> Date: Mon Nov 29 05:17:57 2021 -0500 types(ApplicationCommandManager): Deprecate old `*Data` type usages and allow camel cased dapi types to be used (discordjs#6959)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #6248
Tested with the following inputs, and all worked just fine:
message.react('<:CrowOfJudgement:697940233710338148>');message.react(':CrowOfJudgement:697940233710338148');message.react('CrowOfJudgement:697940233710338148');message.react('697940233710338148');message.react('😄');message.react('%F0%9F%98%84');message.react(message.guild.emojis.cache.first());message.react({ id: '697940233710338148' });message.react({ name: '😄' });The only case that didn't was passing an encoded emoji inside
{ name }, since it getsencodeURIComponent'd twice:message.react({ name: '%F0%9F%98%84' });However, this doesn't work in latest stable (13.3.1), so it's not breaking anything.
Question: Should I deprecate
BaseGuildEmojiManager#resolveIdentifier? With this PR, the library will not longer use this method. However, we do not offer a public alternative (Util.resolvePartialEmojiandUtil.parseEmojiare both private).Status and versioning classification: