Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: make required a boolean #7307

Merged
merged 1 commit into from Jan 20, 2022
Merged

types: make required a boolean #7307

merged 1 commit into from Jan 20, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Closes #7305

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni
Copy link
Member Author

suneettipirneni commented Jan 20, 2022 •
edited

CI failing because of /REST test

@iCrawl iCrawl added this to the builders v1 milestone Jan 20, 2022
@iCrawl iCrawl merged commit c10afea into discordjs:main Jan 20, 2022
@suneettipirneni suneettipirneni deleted the builders/fix/required-type branch January 20, 2022 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:builders semver:patch typings
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

Incorrect type for required property of ApplicationCommandOptionBase
3 participants
@suneettipirneni @iCrawl @SpaceEEC