Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(embed): add setFields #7322

Merged
merged 1 commit into from Jan 24, 2022
Merged

feat(embed): add setFields #7322

merged 1 commit into from Jan 24, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Jan 22, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

This PR adds the Embed#setFields method to /builders, for compatibility with djs and to prepare for #7067

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@iCrawl iCrawl modified the milestones: collection v1, builders v1 Jan 22, 2022
@iCrawl iCrawl merged commit bcc5cda into discordjs:main Jan 24, 2022
@ImRodry ImRodry deleted the feat-embed-setfields branch January 24, 2022 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Mysterious-Dev Mysterious-Dev Mysterious-Dev approved these changes

Assignees
No one assigned
Labels
packages:builders semver:minor
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ImRodry @vladfrangu @iCrawl @kyranet @SpaceEEC @Mysterious-Dev