Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(embed): mark properties as readonly #7332

Merged
merged 1 commit into from Jan 24, 2022
Merged

refactor(embed): mark properties as readonly #7332

merged 1 commit into from Jan 24, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@iCrawl iCrawl added this to the builders v1 milestone Jan 24, 2022
@iCrawl iCrawl merged commit 31768fc into discordjs:main Jan 24, 2022
@suneettipirneni suneettipirneni deleted the builders/refactor/readonly-props branch February 7, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:builders semver:minor
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@suneettipirneni @iCrawl @kyranet @SpaceEEC