Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix some typos #7393

Merged
merged 1 commit into from Feb 2, 2022
Merged

fix: fix some typos #7393

merged 1 commit into from Feb 2, 2022

Conversation

DTrombett
Copy link
Contributor

@DTrombett DTrombett commented Feb 2, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

Fixed some typos across the packages.

NOTE: There are a couple of things that may break in some ways:

  • sweepStageInstnaces -> sweepStageInstances in typings; it was ok in the code so there shouldn't be any issues, at least for non-typescript users
  • lastHeatbeatSend -> lastHeartbeatSend; is a private property and shouldn't be used

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@kyranet kyranet modified the milestone: discord.js v14 Feb 2, 2022
@iCrawl iCrawl merged commit 92a04f4 into discordjs:main Feb 2, 2022
@DTrombett DTrombett deleted the fix/typos branch February 2, 2022 21:29
@DTrombett DTrombett mentioned this pull request Feb 21, 2022
Merged
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
@DTrombett
fix: fix some typos (discordjs#7393)
36d84a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:builders packages:discord.js packages:rest packages:voice
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@DTrombett @iCrawl @kyranet @SpaceEEC