refactor(builders-methods): make methods consistent #7395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
ImRodry
reviewed
Feb 3, 2022
...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts
Outdated
Show resolved
Hide resolved
...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts
Outdated
Show resolved
Hide resolved
suneettipirneni
requested changes
Feb 3, 2022
...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts
Outdated
Show resolved
Hide resolved
imranbarbhuiya
suggested changes
Feb 4, 2022
vladfrangu
requested changes
Feb 4, 2022
...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts
Outdated
Show resolved
Hide resolved
...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
SpaceEEC
approved these changes
Feb 9, 2022
thebigwolfy
approved these changes
Feb 9, 2022
iCrawl
approved these changes
Feb 9, 2022
|
There are merge conflicts. |
kyranet
approved these changes
Feb 11, 2022
vladfrangu
approved these changes
Feb 12, 2022
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This makes builders methods such as
<Embed>addFieldsand<SlashCommand..Option>.addChoice,<ActionRow>.setComponents,<SlashCommand..Option>.setChoicesand<Embed>.setFieldsconsistentnow
<SlashCommand..Option>'s.setChoices,.addChoices,.addChoiceall take in Objects like the embed methods instead of a tuple array<SlashCommand..Option>'s.setChoicesandaddChoicesas well as<ActionRow>.setComponentsall now take a rest parameter instead of an array of their respective inputs to be more consistent with methods such as<Embed>.setFieldsStatus and versioning classification: