Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove conditional autocomplete option return types #7396

Merged
merged 2 commits into from Feb 9, 2022
Merged

refactor: remove conditional autocomplete option return types #7396

merged 2 commits into from Feb 9, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Remove conditional return types from autocomplete options. These did not work as intended.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

almeidx
almeidx reviewed Feb 3, 2022
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consistency. Alternatively, the annotation should be removed from all the other ones

...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts Outdated Show resolved Hide resolved
...interactions/slashCommands/mixins/ApplicationCommandOptionWithChoicesAndAutocompleteMixin.ts Outdated Show resolved Hide resolved
vladfrangu
vladfrangu approved these changes Feb 4, 2022
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you apply @almeidx's request, LGTM

@iCrawl iCrawl added this to the builders v1 milestone Feb 5, 2022
@suneettipirneni @almeidx
Apply suggestions from code review
d12addd 
Co-authored-by: Almeida <almeidx@pm.me>
@iCrawl iCrawl merged commit 0909824 into discordjs:main Feb 9, 2022
@suneettipirneni suneettipirneni deleted the builders/refactor/remove-conditional-types branch July 6, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
packages:builders refactor semver:patch
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@suneettipirneni @vladfrangu @iCrawl @kyranet @almeidx