Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeEmbed should not validate input on #addFields call #7416

Closed
almostSouji opened this issue Feb 6, 2022 · 0 comments · Fixed by #7418
Closed

UnsafeEmbed should not validate input on #addFields call #7416

almostSouji opened this issue Feb 6, 2022 · 0 comments · Fixed by #7418

Comments

@almostSouji
Copy link
Member

Which package is this bug report for?

discord.js

Issue description

this.fields.push(...Embed.normalizeFields(...fields));

The UnsafeEmbed's addFields method introduced in #7387 should not call the static #normalizeFIelds from the safe Embed, as it causes validation.

Code sample

No response

Package version

discord.js@14.0.0-dev.1644106039.d8184f9

Node.js version

v16.9.0

Operating system

5.16.4-arch1-1

Priority this issue should have

Medium (should be fixed soon)

Which partials do you have configured?

Not applicable (subpackage bug)

Which gateway intents are you subscribing to?

Not applicable (subpackage bug)

I have tested this issue on a development release

d8184f9

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant