fix: unsafe embed builder field normalization #7418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
suneettipirneni
force-pushed
the
builders/fix/unsafe-field-normalization
branch
from
0a224d7
to
0fc9665
Compare
suneettipirneni
changed the title
suneettipirneni
force-pushed
the
builders/fix/unsafe-field-normalization
branch
from
0fc9665
to
47e3c23
Compare
SpaceEEC
approved these changes
Feb 7, 2022
iCrawl
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Uses the unsafe field normalizer for unsafe embeds. Closes #7416
This also adds a new interface type:
JSONEncodable<T>, for better type enforcement and reusability.Status and versioning classification: