Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(commands): attachment options #7441

Merged
merged 1 commit into from Feb 13, 2022
Merged

feat(commands): attachment options #7441

merged 1 commit into from Feb 13, 2022

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Feb 10, 2022

Please describe the changes this PR makes and why it should be merged:
Pretty simple backport of #7200, not much to change here. Will need the same upstream discord-api-types PRs merged though.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

xHyroM
xHyroM approved these changes Feb 10, 2022
View reviewed changes
Copy link
Contributor

@xHyroM xHyroM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@xHyroM xHyroM mentioned this pull request Feb 10, 2022
Merged
2 tasks
@JaronZ JaronZ mentioned this pull request Feb 12, 2022
Closed
2 tasks
@iCrawl iCrawl changed the title feat(commands): attachment options for v13 feat(commands): attachment options Feb 13, 2022
@iCrawl iCrawl merged commit 5bcca8b into discordjs:v13 Feb 13, 2022
@vladfrangu vladfrangu added this to the discord.js v13.7 milestone Feb 25, 2022
@monbrey monbrey deleted the attachment-option branch April 17, 2022 21:47
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@thebigwolfy thebigwolfy thebigwolfy approved these changes

@xHyroM xHyroM xHyroM approved these changes

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v13.7
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@monbrey @vladfrangu @iCrawl @kyranet @SpaceEEC @thebigwolfy @xHyroM