Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): setX should take rest parameters #7461

Merged
merged 2 commits into from Feb 15, 2022
Merged

fix(components): setX should take rest parameters #7461

merged 2 commits into from Feb 15, 2022

Conversation

muchnameless
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
regression from #7422

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@kyranet kyranet added this to the builders v1 milestone Feb 13, 2022
@iCrawl iCrawl merged commit 3617359 into discordjs:main Feb 15, 2022
@muchnameless muchnameless deleted the fix-set branch February 15, 2022 18:18
almeidx pushed a commit to almeidx/discord.js that referenced this pull request Feb 15, 2022
@muchnameless @almeidx
fix(components): setX should take rest parameters (discordjs#7461)
d4566c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:builders regression semver:patch
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@muchnameless @iCrawl @kyranet @SpaceEEC