Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add API v10 support #7477

Merged
merged 3 commits into from Mar 15, 2022
Merged

feat: add API v10 support #7477

merged 3 commits into from Mar 15, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Feb 16, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

Pending next -types release
released

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@suneettipirneni suneettipirneni force-pushed the discordjs/feat/v10-support branch 2 times, most recently from 2d3b3ce to 1e9981c Compare February 16, 2022 17:08
@almeidx
Copy link
Member

almeidx commented Feb 18, 2022

Looks like there has been a -types release

almeidx
almeidx reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The root README should be updated too

@suneettipirneni suneettipirneni marked this pull request as ready for review February 18, 2022 02:48
@suneettipirneni suneettipirneni force-pushed the discordjs/feat/v10-support branch 5 times, most recently from d75fe8d to 5d9ddcc Compare February 18, 2022 03:27
@kyranet
Copy link
Member

kyranet commented Feb 24, 2022

This PR needs quite the rebase.

kyranet
kyranet approved these changes Feb 25, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only thing is that I would bump discord-api-types to 0.27.3 to not conflict with #7023, but it's fine otherwise.

@iCrawl
Copy link
Member

iCrawl commented Feb 26, 2022

This needs a rebase.

@suneettipirneni suneettipirneni marked this pull request as draft March 1, 2022 19:12
@iCrawl
Copy link
Member

iCrawl commented Mar 6, 2022

This needs a rebase.

@suneettipirneni suneettipirneni marked this pull request as ready for review March 14, 2022 14:56
@iCrawl iCrawl merged commit 72577c4 into discordjs:main Mar 15, 2022
@SuperchupuDev SuperchupuDev mentioned this pull request Mar 15, 2022
Merged
@suneettipirneni suneettipirneni deleted the discordjs/feat/v10-support branch July 6, 2022 15:21
cyan-2048 pushed a commit to cyan-2048/discord.js that referenced this pull request May 8, 2024
@suneettipirneni
feat: add API v10 support (discordjs#7477)
c4ad23b 
* feat: add API v10 support

* refactor: update deps

* chore: rebase fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Mysterious-Dev Mysterious-Dev Mysterious-Dev approved these changes

Assignees
No one assigned
Labels
packages:builders packages:discord.js packages:rest packages:voice
Projects
discord.js
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@suneettipirneni @almeidx @kyranet @iCrawl @vladfrangu @SpaceEEC @Mysterious-Dev