Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types: V13 channel create overloads fix #7480

Merged
merged 2 commits into from Feb 20, 2022
Merged

types: V13 channel create overloads fix #7480

merged 2 commits into from Feb 20, 2022

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Backports #7294 to version 13.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

kyranet
kyranet approved these changes Feb 16, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v13's overloads, more like annoying overloads

vladfrangu
vladfrangu approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visible waiving of a broom

@iCrawl iCrawl modified the milestone: discord.js v14 Feb 17, 2022
@kyranet kyranet mentioned this pull request Feb 19, 2022
Closed
@iCrawl iCrawl added this to the discord.js v13.7 milestone Feb 20, 2022
@iCrawl iCrawl merged commit 0b54089 into discordjs:v13 Feb 20, 2022
@Jiralite Jiralite deleted the fix/channel-create-types branch February 20, 2022 13:37
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v13.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jiralite @vladfrangu @iCrawl @kyranet