Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(embed): remove array support in favor of rest params #7498

Merged
merged 1 commit into from Feb 20, 2022
Merged

refactor(embed): remove array support in favor of rest params #7498

merged 1 commit into from Feb 20, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Feb 18, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:
Other methods from builders do not support arrays either and it seems like it was a conscious decision #7395 (comment)

  • removed support for arrays from addFields() and spliceFields()
  • removed the normalizeFields() method as it no longer serves a purpose

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

kyranet
kyranet reviewed Feb 18, 2022
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one doubt:

packages/builders/src/messages/embed/Embed.ts Show resolved Hide resolved
@iCrawl iCrawl added this to the builders v1 milestone Feb 20, 2022
@iCrawl iCrawl merged commit b3fa2ec into discordjs:main Feb 20, 2022
@almeidx almeidx deleted the embed branch February 20, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muchnameless muchnameless muchnameless left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
packages:builders refactor semver:major
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @muchnameless @vladfrangu @iCrawl @kyranet