Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(components): default set boolean methods to true #7502

Merged
merged 1 commit into from Feb 20, 2022

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented Feb 18, 2022

Please describe the changes this PR makes and why it should be merged:

This PR brings #6279 back to builders

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure...but I built builders in mind with explicit data being passed in, and it's how chat input command options work 🤷

@iCrawl iCrawl added this to the builders v1 milestone Feb 20, 2022
@iCrawl iCrawl merged commit b122149 into discordjs:main Feb 20, 2022
@ImRodry ImRodry deleted the feat/builders-parity branch February 20, 2022 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants