Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only check instanceof Component once #7546

Merged
merged 1 commit into from Feb 26, 2022
Merged

fix: only check instanceof Component once #7546

merged 1 commit into from Feb 26, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Previously a check was done for each component type. This simplifies the logic to one check for a class-based component.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@SpaceEEC SpaceEEC added this to the discord.js v14 milestone Feb 25, 2022
@iCrawl iCrawl merged commit 0aa4851 into discordjs:main Feb 26, 2022
@iCrawl iCrawl modified the milestones: discord.js v14, builders v1 Feb 26, 2022
@suneettipirneni suneettipirneni deleted the fix/builders/check-components-once branch July 6, 2022 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:builders semver:patch
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@suneettipirneni @vladfrangu @iCrawl @kyranet @SpaceEEC @ImRodry