New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace zod with shapeshift #7547
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just FYI, you'll need to update lengthGte
to lengthGe
and lengthLte
to lengthLe
once v2 is released.
Also, we're not releasing v2 just yet, we need to write documentation for everything and write tests until coverage reaches 100%.
This needs a rebase. |
@sapphire/shapeshift v2 just released, you can now rebase the PR and use it 🎉 |
done |
.../builders/src/interactions/slashCommands/mixins/ApplicationCommandOptionChannelTypesMixin.ts
Outdated
Show resolved
Hide resolved
.../builders/src/interactions/slashCommands/mixins/ApplicationCommandOptionChannelTypesMixin.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: John <36800359+Khasms@users.noreply.github.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
.../builders/src/interactions/slashCommands/mixins/ApplicationCommandOptionChannelTypesMixin.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tfw was looking at some builders code, realised I never checked if this was already made and turns out it already was.
Please describe the changes this PR makes and why it should be merged:
wait for
Status and versioning classification: