Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace zod with shapeshift #7547

Merged
merged 21 commits into from Apr 9, 2022
Merged

refactor: replace zod with shapeshift #7547

merged 21 commits into from Apr 9, 2022

Conversation

imranbarbhuiya
Copy link
Contributor

@imranbarbhuiya imranbarbhuiya commented Feb 25, 2022

Please describe the changes this PR makes and why it should be merged:
wait for

  • v2 release

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@imranbarbhuiya
Copy link
Contributor Author

imranbarbhuiya commented Feb 25, 2022

ci will fail bc union takes rest param and I'm sure it isn't intentional. But still union needs a type fix so i'll update it when they'll fix the type.

Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just FYI, you'll need to update lengthGte to lengthGe and lengthLte to lengthLe once v2 is released.

Also, we're not releasing v2 just yet, we need to write documentation for everything and write tests until coverage reaches 100%.

@iCrawl
Copy link
Member

iCrawl commented Mar 6, 2022

This needs a rebase.

@kyranet
Copy link
Member

kyranet commented Mar 13, 2022

@sapphire/shapeshift v2 just released, you can now rebase the PR and use it 🎉

@imranbarbhuiya imranbarbhuiya marked this pull request as ready for review March 14, 2022 04:55
@imranbarbhuiya
Copy link
Contributor Author

@sapphire/shapeshift v2 just released, you can now rebase the PR and use it 🎉

done

imranbarbhuiya and others added 2 commits March 14, 2022 12:30
Co-authored-by: John <36800359+Khasms@users.noreply.github.com>
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
Copy link
Contributor

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tfw was looking at some builders code, realised I never checked if this was already made and turns out it already was.

@iCrawl iCrawl merged commit 3c0bbac into discordjs:main Apr 9, 2022
@imranbarbhuiya imranbarbhuiya deleted the shapeshift branch April 9, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants