Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Validate select menu options #7566

Merged
merged 4 commits into from Mar 24, 2022
Merged

fix: Validate select menu options #7566

merged 4 commits into from Mar 24, 2022

Conversation

suneettipirneni
Copy link
Member

Please describe the changes this PR makes and why it should be merged:

Select menu options are now properly validated.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@suneettipirneni suneettipirneni changed the title Fix/validate-selectmenu-options Fix: Validatate select menu options Feb 25, 2022
@suneettipirneni suneettipirneni changed the title Fix: Validatate select menu options Fix: Validate select menu options Feb 25, 2022
@ImRodry
Copy link
Contributor

ImRodry commented Feb 25, 2022

psst commitlint

@suneettipirneni suneettipirneni changed the title Fix: Validate select menu options fix: Validate select menu options Feb 25, 2022
@iCrawl iCrawl added this to the builders v1 milestone Feb 26, 2022
@iCrawl iCrawl merged commit b1d63d9 into discordjs:main Mar 24, 2022
@suneettipirneni suneettipirneni deleted the fix/validate-selectmenu-options branch July 6, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
packages:builders semver:patch
Projects
discord.js
Archived in project
Milestone
builders v1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@suneettipirneni @ImRodry @vladfrangu @iCrawl @kyranet @SpaceEEC @almeidx