New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove obsolete builder methods #7590
Conversation
fdc90f3
to
2301ffb
Compare
2301ffb
to
7111a2f
Compare
Shouldn't it also be changed in discord.js/packages/builders/docs/examples/Slash Command Builders.md Lines 74 to 78 in 53defb8
|
ffd9037
to
21757ce
Compare
21757ce
to
ca708f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I never liked this removal of singular vs multiple additions but 🤷 LGTM
Considering this message and the fact that builders 0.13.0 is required for upgrading to 13.7.0, it would have been nice if this breaking change were communicated better. |
Please describe the changes this PR makes and why it should be merged:
ApplicationCommandOptionChannelTypesMixin#addChannelType()
ApplicationCommandOptionWithChoicesAndAutocompleteMixin#addChoice()
ApplicationCommandOptionChannelTypesMixin#addChannelTypes()
only accepts rest parameters instead of an arrayStatus and versioning classification: