Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GuildEditData): some fields can be null for v13 #7633

Merged
merged 2 commits into from Apr 19, 2022
Merged

fix(GuildEditData): some fields can be null for v13 #7633

merged 2 commits into from Apr 19, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Mar 10, 2022

Please describe the changes this PR makes and why it should be merged:
Backports the following pull request to v13:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

kane50613
kane50613 suggested changes Mar 14, 2022
View reviewed changes
Copy link

@kane50613 kane50613 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatting

src/structures/Guild.js Show resolved Hide resolved
@iCrawl iCrawl added this to the discord.js v13.7 milestone Apr 17, 2022
@iCrawl iCrawl merged commit 816936e into discordjs:v13 Apr 19, 2022
@almeidx almeidx deleted the guild-edit-fix-v13 branch April 19, 2022 14:43
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kane50613 kane50613 kane50613 requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v13.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @vladfrangu @iCrawl @SpaceEEC @kane50613