Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RichPresenceAssets): Remove non-breaking custom image support #7636

Merged
merged 2 commits into from Apr 9, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Mar 11, 2022

Due to #7635, YouTube has been removed from parsing here. The rest will be removed in version 14.

@Jiralite Jiralite changed the title Revert "feat: Add custom image support to version 13" refactor: Remove non-breaking custom image support Mar 11, 2022
@Jiralite Jiralite changed the title refactor: Remove non-breaking custom image support refactor(RichPresenceAssets): Remove non-breaking custom image support Mar 11, 2022
@ImRodry
Copy link
Contributor

ImRodry commented Mar 11, 2022

“remove support” and “non-breaking” don’t really go well together, how is this not breaking?

@Jiralite
Copy link
Member Author

This isn't in stable.

@ImRodry
Copy link
Contributor

ImRodry commented Mar 11, 2022

It’s still v13, wdym

@imranbarbhuiya
Copy link
Contributor

It’s still v13, wdym

he mean yt isn't in v13.6 release only in v13 branch for v13.7 release so it can be removed.

@iCrawl iCrawl merged commit b9c5676 into discordjs:v13 Apr 9, 2022
@Jiralite Jiralite deleted the revert-7557-13-rpa branch April 9, 2022 11:07
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

7 participants