feat: Slash command localization for builders #7683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
iCrawl
approved these changes
Mar 26, 2022
vladfrangu
requested changes
Mar 26, 2022
packages/builders/src/interactions/slashCommands/SlashCommandBuilder.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/SlashCommandBuilder.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
vladfrangu
requested changes
Mar 26, 2022
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
SpaceEEC
requested changes
Apr 9, 2022
suneettipirneni
force-pushed
the
builders/feat/slash-command-locales
branch
from
9a6881e
to
adcd007
Compare
vladfrangu
previously requested changes
Apr 9, 2022
packages/builders/src/interactions/slashCommands/SlashCommandBuilder.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/SlashCommandBuilder.ts
Outdated
Show resolved
Hide resolved
packages/builders/src/interactions/slashCommands/mixins/NameAndDescription.ts
Outdated
Show resolved
Hide resolved
suneettipirneni
force-pushed
the
builders/feat/slash-command-locales
branch
from
0a330f6
to
dbbe5e5
Compare
suneettipirneni
force-pushed
the
builders/feat/slash-command-locales
branch
from
dbbe5e5
to
4e6c81d
Compare
SpaceEEC
approved these changes
Apr 13, 2022
kyranet
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Allows builders to specific localizations dictionaries for
nameanddescriptionStatus and versioning classification: