New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Remove nickname parsing #7736
Conversation
Should also change this discord.js/packages/discord.js/src/structures/GuildMember.js Lines 430 to 432 in ac4bc3a
|
Discord is removing it, but does it hurt to just keep it in the parsing section for legacy reasons (parsing messages where this was still the case)? I do agree with removing it from #toString, so d.js doesn't send it anymore, but do not see any benefit in removing it from the parsing regex |
Agreed with @almostSouji, let's remove it just from toString() (aka make toString() call this.user.toString() :megu:) |
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: