Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove nickname parsing #7736

Merged
merged 6 commits into from Apr 12, 2022

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Apr 1, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@Jiralite Jiralite marked this pull request as draft April 1, 2022 18:00
@ImRodry
Copy link
Contributor

ImRodry commented Apr 3, 2022

Should also change this

toString() {
return `<@${this.nickname ? '!' : ''}${this.user.id}>`;
}

@almostSouji
Copy link
Member

Discord is removing it, but does it hurt to just keep it in the parsing section for legacy reasons (parsing messages where this was still the case)? I do agree with removing it from #toString, so d.js doesn't send it anymore, but do not see any benefit in removing it from the parsing regex

@vladfrangu
Copy link
Member

Agreed with @almostSouji, let's remove it just from toString() (aka make toString() call this.user.toString() :megu:)

@Jiralite Jiralite marked this pull request as ready for review April 4, 2022 11:19
@iCrawl iCrawl merged commit 78a3afc into discordjs:main Apr 12, 2022
@Jiralite Jiralite deleted the refactor/nickname-parsing branch April 12, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

9 participants