Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for localized slash commands (v13 backport) #7766

Merged
merged 3 commits into from Apr 14, 2022
Merged

feat: add support for localized slash commands (v13 backport) #7766

merged 3 commits into from Apr 14, 2022

Conversation

xHyroM
Copy link
Contributor

@xHyroM xHyroM commented Apr 10, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:
Backports #7684

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@kyranet kyranet added this to the discord.js v13.7 milestone Apr 10, 2022
@kyranet kyranet linked an issue Apr 10, 2022 that may be closed by this pull request
Slash Command Localization(v13) #7765
Closed
Jiralite
Jiralite requested changes Apr 13, 2022
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the changes from #7794!

@xHyroM
Copy link
Contributor Author

xHyroM commented Apr 13, 2022

Please make the changes from #7794!

When I get home, I'll do that.

@iCrawl iCrawl merged commit 022e138 into discordjs:v13 Apr 14, 2022
@DarrenOfficial DarrenOfficial mentioned this pull request May 6, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v13.7
Development

Successfully merging this pull request may close these issues.

Slash Command Localization(v13)
6 participants
@xHyroM @vladfrangu @iCrawl @kyranet @SpaceEEC @Jiralite