Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for guild forums #7791

Merged
merged 60 commits into from Sep 18, 2022
Merged

feat: add support for guild forums #7791

merged 60 commits into from Sep 18, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Apr 13, 2022 •
edited by SpaceEEC

Please describe the changes this PR makes and why it should be merged:

WIP/Draft based on known documentation of guild forum threads:

Status and versioning classification:
Please move lines that apply to you out of the comment:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

ImRodry
ImRodry reviewed Apr 13, 2022
View reviewed changes
Copy link
Contributor

@ImRodry ImRodry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at the implementation in Discord, I had the feeling forum threads would act differently from text channel threads because of things like the reactions and the OP tag, are you sure this isn't the case?

packages/discord.js/src/index.js Outdated Show resolved Hide resolved
packages/discord.js/src/managers/ThreadManager.js Outdated Show resolved Hide resolved
@suneettipirneni
Copy link
Member Author

From looking at the implementation in Discord, I had the feeling forum threads would act differently from text channel threads because of things like the reactions and the OP tag, are you sure this isn't the case?

That isn't in the docs:

WIP/Draft based on known documentation of guild forum threads:

@ImRodry
Copy link
Contributor

ImRodry commented Apr 13, 2022

Well you didn't add the channel flags

@suneettipirneni
Copy link
Member Author

suneettipirneni commented Apr 13, 2022 •
edited

Well you didn't add the channel flags

It's still a draft PR

@iCrawl iCrawl added this to the discord.js v14 milestone Apr 17, 2022
@vladfrangu
Copy link
Member

This needs a rebase

@vladfrangu vladfrangu mentioned this pull request May 31, 2022
Closed
@BenPatersonxx

This comment was marked as off-topic.

Sign in to view
aiko-chan-ai added a commit to aiko-chan-ai/discord.js-selfbot-v13 that referenced this pull request Jun 15, 2022
@aiko-chan-ai
feat: add support for guild forums
47d865d 
waiting discordjs/discord.js#7791
@didinele didinele mentioned this pull request Jun 17, 2022
Merged
@GravIos3

This comment was marked as spam.

Sign in to view
DraftProducts
DraftProducts approved these changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@DraftProducts DraftProducts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@almeidx
Copy link
Member

almeidx commented Jul 19, 2022

@vercel
Copy link

vercel bot commented Jul 20, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 17, 2022 at 11:45PM (UTC)

@vercel vercel bot temporarily deployed to Preview July 20, 2022 16:54 Inactive
@vercel vercel bot temporarily deployed to Preview July 20, 2022 17:16 Inactive
@iCrawl iCrawl force-pushed the discord.js/feat/guild-forums branch from 35c676a to 76d94ea Compare July 20, 2022 21:03
@iCrawl iCrawl requested a review from kyranet September 17, 2022 23:23
@Jiralite @kyranet
fix: handle magical null case
45bd884 
Co-authored-by: A. Román <kyradiscord@gmail.com>
@kodiakhq kodiakhq bot merged commit 8a8d519 into discordjs:main Sep 18, 2022
@aiko-chan-ai aiko-chan-ai mentioned this pull request Sep 21, 2022
Merged
@guinhx
Copy link

guinhx commented Mar 29, 2023

any news?

@Jiralite
Copy link
Member

Jiralite commented Mar 29, 2023 •
edited

That's vague. If you have a query, you can ask on the Discord server or create a new discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JJRcop JJRcop JJRcop left review comments

@Jiralite Jiralite Jiralite requested changes

@ImRodry ImRodry ImRodry left review comments

@RedGuy12 RedGuy12 RedGuy12 left review comments

@jaw0r3k jaw0r3k jaw0r3k left review comments

@muchnameless muchnameless muchnameless requested changes

@almeidx almeidx almeidx requested changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@DraftProducts DraftProducts DraftProducts approved these changes

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v14.4
Development

Successfully merging this pull request may close these issues.

None yet