Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: backport text-in-voice support to v13 #7999

Merged
merged 3 commits into from Jun 5, 2022
Merged

feat: backport text-in-voice support to v13 #7999

merged 3 commits into from Jun 5, 2022

Conversation

suneettipirneni
Copy link
Member

@suneettipirneni suneettipirneni commented Jun 4, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

Backports #6921 and #8002 to v13

Closes #7998
Closes #7996
Closes #7995

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@suneettipirneni @Jiralite
Update src/structures/interfaces/TextBasedChannel.js
8f6235b 
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@nyapat nyapat mentioned this pull request Jun 4, 2022
Closed
This was linked to issues Jun 4, 2022
Support Text In Voice #7998
Closed
Caching webhooks messages in voice channel (text for voice channel) #7995
Closed
@tyzbit tyzbit mentioned this pull request Jun 5, 2022
Closed
hakatashi added a commit to tsg-ut/slackbot that referenced this pull request Jun 5, 2022
@hakatashi
Update discord.js to the version with text-in-voice
1dc1df3 
NOTE: This should be reverted after the pull request discordjs/discord.js#7999 is merged into the main branch
@hakatashi hakatashi mentioned this pull request Jun 5, 2022
Merged
@iCrawl iCrawl added this to the discord.js v13.8 milestone Jun 5, 2022
This was linked to issues Jun 5, 2022
Interaction fetching reply bug #7993
Closed
Can't handle text message in voice channel #7996
Closed
SpaceEEC
SpaceEEC previously requested changes Jun 5, 2022
View reviewed changes
Copy link
Member

@SpaceEEC SpaceEEC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one documentation change.

src/structures/VoiceChannel.js Show resolved Hide resolved
@kyranet kyranet requested a review from SpaceEEC June 5, 2022 15:16
@iCrawl iCrawl merged commit ddfe15b into discordjs:v13 Jun 5, 2022
@suneettipirneni suneettipirneni deleted the backport/text-in-voice branch June 5, 2022 16:43
DraftProducts pushed a commit to DraftBot/discord.js that referenced this pull request Aug 29, 2022
@suneettipirneni @DraftProducts
feat: backport text-in-voice support to v13 (discordjs#7999)
1b29825
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advaith1 advaith1 advaith1 left review comments

@Jiralite Jiralite Jiralite left review comments

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v13.8
7 participants
@suneettipirneni @advaith1 @vladfrangu @iCrawl @kyranet @SpaceEEC @Jiralite