Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types(GuildChannel): fix type of .isText() method #8061

Merged
merged 1 commit into from Jun 13, 2022
Merged

types(GuildChannel): fix type of .isText() method #8061

merged 1 commit into from Jun 13, 2022

Conversation

Syjalo
Copy link
Contributor

@Syjalo Syjalo commented Jun 10, 2022

Please describe the changes this PR makes and why it should be merged:
This pr fixes type of GuildChannel#isText() method

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jun 10, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Jun 10, 2022 at 10:50AM (UTC)

@vercel vercel bot temporarily deployed to Preview June 10, 2022 10:50 Inactive
@nowifi4u
Copy link

nowifi4u commented Jun 10, 2022 •
edited

@Syjalo
Why even fix it when there is already correct typing for the method in class's parent?
Simply removing the override will fix it

@Syjalo
Copy link
Contributor Author

Syjalo commented Jun 10, 2022

@Syjalo Why even fix it when there is already correct typing for the method in class's parent? Simply removing the override will fix it

DM channels aren't a GuildChannel. That's why.

@kyranet kyranet added this to the discord.js v13.8.1 milestone Jun 12, 2022
@iCrawl iCrawl merged commit 0d0190a into discordjs:v13 Jun 13, 2022
@Syjalo Syjalo deleted the patch-2 branch June 14, 2022 02:26
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees
No one assigned
Labels
packages:discord.js semver:patch typings
Projects
discord.js
Archived in project
Milestone
discord.js v13.8.1
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Syjalo @nowifi4u @vladfrangu @kyranet @SpaceEEC @iCrawl @Jiralite