Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ModalSubmitInteraction): add isFromMessage() missing method #8092

Merged
merged 1 commit into from Jun 14, 2022

Conversation

Mateo-tem
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Adds isFromMessage() method to ModalSubmitInteraction.
The typings have the method but it really doesn't exist.

When the v14 Modals PR was backported to v13, this method was missing.

(I don't know if this has much importance, but I open this PR to avoid the method error)

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Jun 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Jun 14, 2022 at 3:28AM (UTC)

@vercel vercel bot temporarily deployed to Preview June 14, 2022 03:28 Inactive
@Jiralite Jiralite added this to the discord.js v13.8.1 milestone Jun 14, 2022
@iCrawl iCrawl merged commit 0ab2227 into discordjs:v13 Jun 14, 2022
@Mateo-tem Mateo-tem deleted the modal-is-from-message branch June 14, 2022 23:03
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants