refactor: deprecate $ prefix from ws.properties keys
#8095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
As is, this is a breaking change |
|
We should do this in a non-breaking way, yes. Accept both but only send the "new" way. |
|
alright then, since the prefix is apparently dropped server-side by discord i just made the typings accept both |
|
🤔 Can you deprecate the prefixed keys? |
Jiralite
reviewed
Jun 14, 2022
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
SuperchupuDev
changed the title
$ prefix from ws.properties keys for v13$ prefix from ws.properties keys
vladfrangu
approved these changes
Jun 14, 2022
iCrawl
approved these changes
Jun 14, 2022
Jiralite
approved these changes
Jun 14, 2022
kyranet
approved these changes
Jun 16, 2022
DraftProducts
approved these changes
Jun 16, 2022
|
@SuperchupuDev Could you check the failing check? (vercel) |
|
@JosPoka Vercel only passes on PRs pointing to main, it'll always fail for PRs to v13, don't mind it. |
vladfrangu
approved these changes
Jun 16, 2022
SpaceEEC
approved these changes
Jun 17, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
$prefix fromws.propertieskeys #8094 (comment)Status and versioning classification: