Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: partially backport perms v2 for v13 #8162

Merged
merged 3 commits into from Jun 23, 2022
Merged

feat: partially backport perms v2 for v13 #8162

merged 3 commits into from Jun 23, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jun 23, 2022 •
edited

Please describe the changes this PR makes and why it should be merged:

  • Backports the new command structure and creation of commands from the following pr to v13
  • Deprecates defaultPermission
  • Fixes ApplicationCommand.edit() and ApplicationCommandManager.edit() requiring name and description options

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jun 23, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Jun 23, 2022 at 3:51PM (UTC)

@vercel vercel bot temporarily deployed to Preview June 23, 2022 15:02 Inactive
@vercel vercel bot temporarily deployed to Preview June 23, 2022 15:36 Inactive
@vercel vercel bot temporarily deployed to Preview June 23, 2022 15:36 Inactive
@vercel vercel bot temporarily deployed to Preview June 23, 2022 15:51 Inactive
@iCrawl iCrawl merged commit 125696f into discordjs:v13 Jun 23, 2022
@almeidx almeidx deleted the perms-v2 branch June 23, 2022 22:06
aiko-chan-ai added a commit to aiko-chan-ai/discord.js-selfbot-v13 that referenced this pull request Jun 24, 2022
@aiko-chan-ai
feat: partially backport perms v2 for v13
3877bdf 
v13.9.0 :yay:
discordjs/discord.js#8162
@TheFlash787 TheFlash787 mentioned this pull request Jul 2, 2022
Closed
@TheFlash787
Copy link

Do we know when we might see this PR make it to a release?

@kyranet
Copy link
Member

kyranet commented Jul 2, 2022

Please see https://github.com/discordjs/discord.js/milestone/20, @TheFlash787. We'll release once all tasks in the milestone are complete.

@TheFlash787
Copy link

Please see https://github.com/discordjs/discord.js/milestone/20, @TheFlash787. We'll release once all tasks in the milestone are complete.

Oh my bad, I should've checked the milestones. Thank you so much!

@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

Assignees
No one assigned
Labels
packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v13.9
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@almeidx @TheFlash787 @kyranet @vladfrangu @iCrawl @SpaceEEC @Jiralite