docs(constants): document missing constants #8168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vladfrangu
requested changes
Jun 24, 2022
almeidx
commented
Jun 24, 2022
Comment on lines
-136
to
-146
| /** | ||
| * @deprecated See {@link https://github.com/discord/discord-api-docs/issues/3690 this issue} for more information. | ||
| */ | ||
| APPLICATION_COMMAND_CREATE: 'applicationCommandCreate', | ||
| /** | ||
| * @deprecated See {@link https://github.com/discord/discord-api-docs/issues/3690 this issue} for more information. | ||
| */ | ||
| APPLICATION_COMMAND_DELETE: 'applicationCommandDelete', | ||
| /** | ||
| * @deprecated See {@link https://github.com/discord/discord-api-docs/issues/3690 this issue} for more information. | ||
| */ |
There was a problem hiding this comment.
These were crashing the docgen
There was a problem hiding this comment.
Seems to be this run https://github.com/discordjs/discord.js/runs/7042040198?check_suite_focus=true
There was a problem hiding this comment.
Yep, the "Tests / Documentation (pull_request)" check in the first commit
vladfrangu
approved these changes
Jun 25, 2022
SpaceEEC
approved these changes
Jun 28, 2022
kyranet
approved these changes
Jun 29, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
ConstantstypedefInteractionTypes,InteractionResponseTypes, andMessageComponentTypeswere missing the modal related types.SweeperKeyswas missing in the typingsConstantstypedef alphabeticallyStatus and versioning classification: