Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use non-global flag whilst resolving regular expressions #8178

Merged
merged 1 commit into from Jun 29, 2022

Conversation

Jiralite
Copy link
Member

Backports #8177 to version 13.

@vercel
Copy link

vercel bot commented Jun 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Jun 27, 2022 at 5:13PM (UTC)

@vercel vercel bot temporarily deployed to Preview June 27, 2022 17:13 Inactive
@Jiralite Jiralite added this to the discord.js v13.9 milestone Jun 27, 2022
Copy link
Member

@kyranet kyranet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since it indeed fixes the bug, but I'll add something that can further improve the method.

src/util/DataResolver.js Show resolved Hide resolved
@iCrawl iCrawl merged commit 4063b90 into discordjs:v13 Jun 29, 2022
@Jiralite Jiralite deleted the 13-stateful-regex branch June 29, 2022 23:24
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants