fix(MessageMentions): ignoreRepliedUser option in has()
#8202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
almeidx
changed the title
has() not taking into account replies when ignoreRepliedUser option in has()
|
If we will mention the user in the content and by reply then it also will ignore the content mention. As I said in the issue we should remove the |
DraftProducts
approved these changes
Jul 5, 2022
iCrawl
approved these changes
Jul 27, 2022
kyranet
approved these changes
Jul 28, 2022
SpaceEEC
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Fixes #8201
ignoreRepliedUseroption was not being respected when paired withignoreDirect: falseparsedUsersgetter, which parses user mentions from the message content to address the following comment:ignoreRepliedUseroption inhas()#8202 (comment)ignoreEveryonecondition to the top as the other options don't affect itStatus and versioning classification: