Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ApplicationCommand): add min_length and max_length for string option (v13) #8217

Merged
merged 5 commits into from Jul 6, 2022
Merged

feat(ApplicationCommand): add min_length and max_length for string option (v13) #8217

merged 5 commits into from Jul 6, 2022

Conversation

Mateo-tem
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

Backports #8215 to v13.

Status and versioning classification:

@vercel
Copy link

vercel bot commented Jul 2, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Jul 6, 2022 at 5:02PM (UTC)

@vercel vercel bot temporarily deployed to Preview July 2, 2022 17:26 Inactive
@vercel vercel bot temporarily deployed to Preview July 2, 2022 17:30 Inactive
Jiralite
Jiralite requested changes Jul 2, 2022
View reviewed changes
Copy link
Member

@Jiralite Jiralite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also no documentation here.

@Jiralite Jiralite added this to the discord.js v13.9 milestone Jul 2, 2022
@vercel vercel bot temporarily deployed to Preview July 3, 2022 18:36 Inactive
@Mateo-tem
Copy link
Contributor Author

There is also no documentation here.

Now added!

Mateo-tem
Mateo-tem commented Jul 3, 2022
View reviewed changes
Copy link
Contributor Author

@Mateo-tem Mateo-tem left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change this? Or it's not important?
(The upstream PR had that and I notice those little errors after it was merged)

src/structures/ApplicationCommand.js Outdated Show resolved Hide resolved
src/structures/ApplicationCommand.js Outdated Show resolved Hide resolved
src/structures/ApplicationCommand.js Outdated Show resolved Hide resolved
src/structures/ApplicationCommand.js Outdated Show resolved Hide resolved
@Jiralite
Copy link
Member

Jiralite commented Jul 5, 2022

Should I change this? Or it's not important? (The upstream PR had that and I notice those little errors after it was merged)

Do all of them!

@vercel vercel bot temporarily deployed to Preview July 5, 2022 21:43 Inactive
@Mateo-tem
Copy link
Contributor Author

Mateo-tem commented Jul 5, 2022 •
edited

Do all of them!

Done!

@Mateo-tem
Copy link
Contributor Author

Oh, I noticed that the min_length and max_length fields are missing in ApplicationCommandOptionData, in v14. I'm going to open a PR to add it here.

@vercel vercel bot temporarily deployed to Preview July 6, 2022 17:02 Inactive
@iCrawl iCrawl merged commit a93f4b1 into discordjs:v13 Jul 6, 2022
@Mateo-tem Mateo-tem deleted the string-length-v13 branch July 6, 2022 19:25
@n1ckoates n1ckoates mentioned this pull request Jul 14, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jiralite Jiralite Jiralite requested changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet Awaiting requested review from kyranet

Assignees
No one assigned
Labels
api support packages:discord.js semver:minor
Projects
discord.js
Archived in project
Milestone
discord.js v13.9
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mateo-tem @Jiralite @vladfrangu @iCrawl @SpaceEEC