Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions (v13) #8312

Merged
merged 2 commits into from Jul 20, 2022
Merged

fix(ApplicationCommandManager): allow passing 0n to defaultMemberPermissions (v13) #8312

merged 2 commits into from Jul 20, 2022

Conversation

almeidx
Copy link
Member

@almeidx almeidx commented Jul 18, 2022

Please describe the changes this PR makes and why it should be merged:
Backports #8311

Status and versioning classification:

@vercel
Copy link

vercel bot commented Jul 18, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
discord-js ❌ Failed (Inspect) Jul 19, 2022 at 2:26PM (UTC)

@vercel vercel bot temporarily deployed to Preview July 18, 2022 14:10 Inactive
@vercel vercel bot temporarily deployed to Preview July 19, 2022 14:26 Inactive
@iCrawl iCrawl added this to the discord.js v13.10 milestone Jul 20, 2022
@iCrawl iCrawl merged commit 4cf0555 into discordjs:v13 Jul 20, 2022
@almeidx almeidx deleted the discord.js/fix-default-member-permissions-v13 branch July 20, 2022 18:15
Ikaberry202
Ikaberry202 reviewed Jul 24, 2022
View reviewed changes
Copy link

@Ikaberry202 Ikaberry202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@RedGuy12 RedGuy12 mentioned this pull request Oct 4, 2022
Closed
@RedGuy12 RedGuy12 mentioned this pull request Oct 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ikaberry202 Ikaberry202 Ikaberry202 left review comments

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

@kyranet kyranet Awaiting requested review from kyranet

@vladfrangu vladfrangu Awaiting requested review from vladfrangu

Assignees
No one assigned
Labels
packages:discord.js semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js v13.9.2
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@almeidx @SpaceEEC @Jiralite @Ikaberry202 @iCrawl