Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(GuildBanManager#create): add deleteMessageSeconds #8326

Merged
merged 6 commits into from Sep 8, 2022

Conversation

advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jul 21, 2022

Please describe the changes this PR makes and why it should be merged:

Status and versioning classification:

  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Jul 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Sep 8, 2022 at 1:09PM (UTC)

packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
packages/discord.js/src/structures/GuildMember.js Outdated Show resolved Hide resolved
packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved
packages/discord.js/src/managers/GuildBanManager.js Outdated Show resolved Hide resolved
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #8326 (3923162) into main (4ffdada) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 3923162 differs from pull request most recent head e64a87a. Consider uploading reports for the commit e64a87a to get more accurate results

@@           Coverage Diff           @@
##             main    #8326   +/-   ##
=======================================
  Coverage   86.47%   86.48%           
=======================================
  Files          87       87           
  Lines        8675     8679    +4     
  Branches     1110     1110           
=======================================
+ Hits         7502     7506    +4     
  Misses       1131     1131           
  Partials       42       42           
Flag Coverage Δ
builders 100.00% <ø> (ø)
collection 100.00% <ø> (ø)
proxy 74.10% <ø> (ø)
rest 91.99% <ø> (ø)
utilities 100.00% <ø> (ø)
voice 63.86% <ø> (ø)
ws 60.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../interactions/slashCommands/SlashCommandBuilder.ts 100.00% <0.00%> (ø)
...s/contextMenuCommands/ContextMenuCommandBuilder.ts 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Jiralite
Copy link
Member

Jiralite commented Aug 3, 2022

Can we get a deprecation warning emitting during runtime too?

@kodiakhq kodiakhq bot merged commit 03fb5b0 into discordjs:main Sep 8, 2022
@advaith1 advaith1 deleted the delete-message-seconds branch September 11, 2022 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

8 participants