Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Client): omit private properties from toJSON #8337

Merged
merged 1 commit into from Jul 22, 2022

Conversation

SpaceEEC
Copy link
Member

@SpaceEEC SpaceEEC commented Jul 22, 2022

Please describe the changes this PR makes and why it should be merged:

This PR changes Client#toJSON (and BaseClient#toJSON) to

  • Remove references to properties that are either no longer on the class or won't get included in the resulting json anyway
  • Are private (and cause an error due to indefinitely recursing) and shouldn't be included in the resulting json

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Jul 22, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Jul 22, 2022 at 3:00PM (UTC)

@iCrawl iCrawl merged commit 830c670 into discordjs:main Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants